Skip to content

feat(ens-controller): Allow supplying ENS network map in constructor#4006

Merged
legobeat merged 6 commits intoMetaMask:mainfrom
legobeat:ens-network-map
Mar 7, 2024
Merged

feat(ens-controller): Allow supplying ENS network map in constructor#4006
legobeat merged 6 commits intoMetaMask:mainfrom
legobeat:ens-network-map

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Mar 1, 2024 •
edited
Loading

Explanation

  • ethereum-ens-network-map is just an undermaintained JSON map - inlining it here makes it more transparent I guess
  • Allow user to supply their own ENS network map in constructor (here called contractsByChainId).
  • chore: tests have been refactored to not rely on snapshots of entire internal state

References

Changelog

@metamask/ens-controller

  • ADDED: Support for Holesky and Sepolia registries.
  • CHANGED: New constructor parameter registriesByChainId allows overriding the default ENS network map.
  • ADDED: get now returns registry address for chain when queried for the name ..

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@legobeat legobeat mentioned this pull request Mar 1, 2024
Merged
13 tasks
@legobeat legobeat force-pushed the ens-network-map branch 2 times, most recently from 8b16a70 to 56d93a1 Compare March 4, 2024 15:31
@legobeat legobeat marked this pull request as ready for review March 4, 2024 15:32
@legobeat legobeat requested a review from a team as a code owner March 4, 2024 15:32
@legobeat legobeat requested a review from cryptodev-2s March 4, 2024 15:33
@legobeat legobeat requested a review from a team March 5, 2024 22:40
cryptodev-2s
cryptodev-2s approved these changes Mar 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat requested a review from mcmire March 7, 2024 11:40
@legobeat legobeat merged commit af668da into MetaMask:main Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

@mcmire mcmire Awaiting requested review from mcmire

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@legobeat @cryptodev-2s