Skip to content

fix: NFT detection running too many times #3917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bergeron merged 3 commits into from
Feb 15, 2024
Merged

fix: NFT detection running too many times #3917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d442498
only start when settings change
bergeron Feb 14, 2024
554b7d0
add unit test
bergeron Feb 14, 2024
d381ac0
Merge branch 'main' into brian/nft-detection-too-many-calls
bergeron Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions packages/assets-controllers/src/NftDetectionController.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,6 +570,34 @@ describe('NftDetectionController', () => {
},
);
});

it('should only re-detect when relevant settings change', async () => {
await withController(
{},
async ({ controller, triggerPreferencesStateChange }) => {
const detectNfts = sinon.stub(controller, 'detectNfts');

// Repeated preference changes should only trigger 1 detection
for (let i = 0; i < 5; i++) {
triggerPreferencesStateChange({
...getDefaultPreferencesState(),
useNftDetection: true,
});
}
await advanceTime({ clock, duration: 1 });
expect(detectNfts.callCount).toBe(1);

// Irrelevant preference changes shouldn't trigger a detection
triggerPreferencesStateChange({
...getDefaultPreferencesState(),
useNftDetection: true,
securityAlertsEnabled: true,
});
await advanceTime({ clock, duration: 1 });
expect(detectNfts.callCount).toBe(1);
},
);
});
});

type WithControllerCallback<ReturnValue> = ({
Expand Down
3 changes: 0 additions & 3 deletions packages/assets-controllers/src/NftDetectionController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,6 @@ export class NftDetectionController extends StaticIntervalPollingControllerV1<
!useNftDetection !== disabled
) {
this.configure({ selectedAddress, disabled: !useNftDetection });
}

if (useNftDetection !== undefined) {
if (useNftDetection) {
this.start();
} else {
Expand Down