Merged
Conversation
3 tasks
Member
Author
|
This is waiting on #3831 |
Base automatically changed from
chore/bump-unsupported-methods-coverage
to
main
January 24, 2024 20:07
1f83f88 to
228e022
Compare
228e022 to
85c0584
Compare
85c0584 to
73de8dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR refactors tests related to user operations methods, to align them with the structure used for other methods.
It also adds test coverage for keyrings that do not support user operations
References
EthKeyringControllerintoKeyringController#3830Changelog
No functional changes
Checklist