Skip to content

Add @metamask/transaction-controller@20.0.0 resolution for SES#3809

Closed
leotm wants to merge 1 commit into
mainfrom
fix/transaction-controller-babel-runtime-0.13.8
Closed

Add @metamask/transaction-controller@20.0.0 resolution for SES#3809
leotm wants to merge 1 commit into
mainfrom
fix/transaction-controller-babel-runtime-0.13.8

Conversation

@leotm

@leotm leotm commented Jan 22, 2024

Copy link
Copy Markdown

Explanation

Spotted a dependency of @metamask/transaction-controller is incompatible with SES

@metamask/core-monorepo@109.0.0
└─┬ @metamask/transaction-controller@20.0.0 -> ./packages/transaction-controller
  └─┬ babel-runtime@6.26.0
    └── regenerator-runtime@0.11.1

regenerator-runtime@0.13.8 contains the fix
if a resolution is a viable option for now (cc @Gudahtt if not i'll close this pr)
but noticed we have no other package.json "resolutions" in this repo

nb: this is more an early preventative measure for when metamask-mobile eventually gets updated to @metamask/transaction-controller@20.0.0 cc @tommasini

References

Spotted in MetaMask/metamask-mobile#8033 (comment)

Changelog

@metamask/package-a

  • : Your change here
  • : Your change here

@metamask/package-b

  • : Your change here
  • : Your change here

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

Resolve

@metamask/core-monorepo@109.0.0 /Users/leo/Documents/GitHub/core
└─┬ @metamask/transaction-controller@20.0.0 -> ./packages/transaction-controller
  └─┬ babel-runtime@6.26.0
    └── regenerator-runtime@0.11.1

to regenerator-runtime@0.13.8 (to fix ses compatibility)
@legobeat

legobeat commented Feb 8, 2024

Copy link
Copy Markdown
Contributor

@leotm I believe this is now resolved as of #3897, which updates regenerator-runtime to 0.14.1 by replacing babel-runtime with @babel/runtime.

@leotm leotm closed this Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants