Merged
Conversation
In cases where users have an enormous amount of tokens, we don't want to slow down our Price API with large requests. To combat this, when fetching token rates, send requests in batches of 100.
Gudahtt
reviewed
Dec 12, 2023
Gudahtt
previously approved these changes
Dec 12, 2023
| [tokenContractAddress]: | ||
| tokenPrice.value * fallbackCurrencyToNativeCurrencyConversionRate, | ||
| [tokenContractAddress]: tokenValue | ||
| ? tokenValue * fallbackCurrencyToNativeCurrencyConversionRate |
Member
There was a problem hiding this comment.
Hmm, I don't totally follow why this additional branch was needed here. Is it now possible for tokenValue to be falsey?
Contributor
Author
There was a problem hiding this comment.
Realistically, no, but because I've changed #fetchAndMapExchangeRatesForUnsupportedNativeCurrency to use #fetchAndMapExchangeRatesForSupportedNativeCurrency, contractExchangeRates is now a type of ContractExchangeRates, and that is defined as:
interface ContractExchangeRates {
[address: string]: number | undefined;
}So that means that tokenValue here is number | undefined.
Member
There was a problem hiding this comment.
Interesting.... that | undefined seems like a mistake, I don't see a case where it is undefined.
Pre-existing issue though, and not a blocker, this doesn't really hurt
Gudahtt
approved these changes
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
In cases where users have an enormous amount of tokens, we don't want to slow down our Price API with large requests. To combat this, when fetching token rates, send requests in batches of 100.
References
Fixes #3573.
Changelog
(Updated in PR)
Checklist