Conversation
3 tasks
base-controller] Add RestrctedControllerMessenger tests for runtime error handlingbase-controller] Add RestrictedControllerMessenger tests for runtime error handling
1a1ca55 to
caa5c6d
Compare
mcmire
reviewed
Nov 17, 2023
Contributor
mcmire
left a comment
There was a problem hiding this comment.
One thing, but otherwise looks good.
Comment on lines
+303
to
+306
| // @ts-expect-error suppressing to test runtime error handling | ||
| restrictedControllerMessenger.registerActionHandler( | ||
| 'CountController:count', | ||
| ); |
Contributor
There was a problem hiding this comment.
Doesn't registerActionHandler take two arguments? Should the // @ts-expect-error be added above the action not above the method call?
Suggested change
| // @ts-expect-error suppressing to test runtime error handling | |
| restrictedControllerMessenger.registerActionHandler( | |
| 'CountController:count', | |
| ); | |
| restrictedControllerMessenger.registerActionHandler( | |
| // @ts-expect-error suppressing to test runtime error handling | |
| 'CountController:count', | |
| () => { | |
| // do nothing | |
| } | |
| ); |
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
RestrictedControllerMessengermethods were not being tested on the basis of compile-time checks: "Branches unreachable with valid types".@ts-expect-erroris used to suppress the compile-time type errors to simulate a JavaScript environment.References
base-controller] AddRestrictedControllerMessengertests for runtime error handling #2059base-controller] Enforce thatRestrictedControllerMessengeris not initialized with internal actions/events in allow lists #2051 (comment)Changelog
@metamask/base-controllerChecklist