Skip to content

Typing fixes for PermissionLogController#1908

Merged
cryptodev-2s merged 3 commits intoimport-permission-log-controllerfrom
231024-typing-permission-log-controller
Oct 24, 2023
Merged

Typing fixes for PermissionLogController#1908
cryptodev-2s merged 3 commits intoimport-permission-log-controllerfrom
231024-typing-permission-log-controller

Conversation

@MajorLift
Copy link
Copy Markdown
Contributor

@MajorLift MajorLift commented Oct 24, 2023

Explanation

Typing fixes for the PermissionLogController:

  • Removes any, adds null checks.
  • Derive request type from JsonRpcRequestStruct.TYPE instead of hardcoding jsonrpc version to "2.0".
  • Narrow req.params type to Json[] where appropriate.

@cryptodev-2s Feel free to cherry-pick, merge, or disregard!

Status

References

Changelog

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@MajorLift MajorLift requested a review from a team as a code owner October 24, 2023 20:56
@MajorLift MajorLift self-assigned this Oct 24, 2023
@MajorLift MajorLift added the team-wallet-framework Deprecated: Please use `team-core-platform` instead. label Oct 24, 2023
@MajorLift MajorLift mentioned this pull request Oct 24, 2023
3 tasks
@MajorLift MajorLift force-pushed the 231024-typing-permission-log-controller branch from 1783794 to 7906e75 Compare October 24, 2023 21:04
@cryptodev-2s cryptodev-2s force-pushed the import-permission-log-controller branch from 735aec1 to 5e3950f Compare October 24, 2023 22:06
@cryptodev-2s cryptodev-2s force-pushed the 231024-typing-permission-log-controller branch from 7906e75 to 51f955d Compare October 24, 2023 22:20
Copy link
Copy Markdown
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cryptodev-2s cryptodev-2s merged commit 1ba3395 into import-permission-log-controller Oct 24, 2023
@cryptodev-2s cryptodev-2s deleted the 231024-typing-permission-log-controller branch October 24, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-wallet-framework Deprecated: Please use `team-core-platform` instead.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants