Typing fixes for PermissionLogController#1908
Merged
cryptodev-2s merged 3 commits intoimport-permission-log-controllerfrom Oct 24, 2023
Merged
Typing fixes for PermissionLogController#1908cryptodev-2s merged 3 commits intoimport-permission-log-controllerfrom
PermissionLogController#1908cryptodev-2s merged 3 commits intoimport-permission-log-controllerfrom
Conversation
3 tasks
1783794 to
7906e75
Compare
735aec1 to
5e3950f
Compare
7906e75 to
51f955d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Typing fixes for the
PermissionLogController:any, adds null checks.jsonrpcversion to "2.0".req.paramstype toJson[]where appropriate.@cryptodev-2s Feel free to cherry-pick, merge, or disregard!
Status
References
Changelog
N/A
Checklist