Bump @metamask/scure-bip39 from 2.1.0 to 2.1.1 by dependabot[bot] · Pull Request #1868 · MetaMask/core

dependabot · 2023-10-19T12:19:15Z

Bumps @metamask/scure-bip39 from 2.1.0 to 2.1.1.

Release notes

Sourced from @metamask/scure-bip39's releases.

2.1.1

Added

Add node.engines field indicating minimum Node.js version 16 to package manifest (#21)

Changed

Bump @noble/hashes from ~1.1.1 to ~1.3.2 (#20)

Bump @scure/base from ~1.1.0 to ~1.1.3 (#20)

Changelog

Sourced from @metamask/scure-bip39's changelog.

[2.1.1]

Added

Add node.engines field indicating minimum Node.js version 16 to package manifest (#21)

Changed

Bump @noble/hashes from ~1.1.1 to ~1.3.2 (#20)

Bump @scure/base from ~1.1.0 to ~1.1.3 (#20)

Commits

8d4b2d2 2.1.1 (#24)
f4b3729 ci: run on ubuntu-latest (22.04) instead of ubuntu-20.04 (#22)
b706ff0 devDeps: bump and unpin mocha, prettier, typescript (#23)
03d5763 deps: @noble/hashes@~1.1.0->~1.3.2 (#20)
cb66d97 Indicate supported Node.js versions; update node versions in CI (#21)
d451024 add yarn.lock v1 (#19)
See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@metamask/scure-bip39](https://github.com/MetaMask/scure-bip39) from 2.1.0 to 2.1.1. - [Release notes](https://github.com/MetaMask/scure-bip39/releases) - [Changelog](https://github.com/MetaMask/scure-bip39/blob/main/CHANGELOG.md) - [Commits](MetaMask/scure-bip39@v2.1.0...v2.1.1) --- updated-dependencies: - dependency-name: "@metamask/scure-bip39" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

dependabot · 2023-10-19T20:42:00Z

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

dependabot · 2023-10-19T20:59:29Z

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

dependabot · 2023-10-20T15:22:33Z

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

dependabot · 2023-10-20T21:52:32Z

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

dependabot · 2023-10-20T22:07:21Z

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

legobeat · 2023-10-22T23:53:54Z

@dependabot recreate

dependabot · 2023-10-23T00:07:02Z

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

dependabot · 2023-10-23T13:20:48Z

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

dependabot · 2023-10-23T19:08:45Z

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

dependabot · 2023-10-23T20:10:37Z

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

dependabot · 2023-10-24T11:12:11Z

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

dependabot · 2023-10-24T14:08:27Z

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

dependabot · 2023-10-24T14:49:35Z

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

dependabot · 2023-10-24T15:03:03Z

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

dependabot · 2023-10-24T15:49:50Z

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

dependabot · 2023-10-24T20:18:36Z

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

dependabot · 2023-10-24T20:52:34Z

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

dependabot · 2023-10-25T09:45:00Z

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

….1.1

legobeat · 2023-10-27T08:21:15Z

Not sure why this is happening now (failing test for KeyringController):

/home/runner/work/core/core/node_modules/@noble/hashes/utils.js:171
    throw new Error('crypto.getRandomValues must be defined');
          ^

Error: crypto.getRandomValues must be defined
    at randomBytes (/home/runner/work/core/core/node_modules/@noble/hashes/src/utils.ts:214:9)
    at Object.generateMnemonic (/home/runner/work/core/core/node_modules/@metamask/scure-bip39/dist/index.js:41:54)
    at HdKeyring.generateRandomMnemonic (/home/runner/work/core/core/node_modules/@metamask/eth-hd-keyring/index.js:37:34)
    at KeyringController.addNewKeyring (/home/runner/work/core/core/node_modules/@metamask/eth-keyring-controller/src/KeyringController.ts:601:15)
    at KeyringController._KeyringController_createFirstKeyTree (/home/runner/work/core/core/node_modules/@metamask/eth-keyring-controller/src/KeyringController.ts:930:21)
    at KeyringController.createNewVaultAndKeychain (/home/runner/work/core/core/node_modules/@metamask/eth-keyring-controller/src/KeyringController.ts:117:5)

mcmire · 2023-10-27T15:08:30Z

@mikesposito Would you happen to have any insight here since you've worked on KeyringController? Have you seen this before?

mcmire · 2023-10-27T15:58:20Z

Hmm... could this change in @noble/hashes cause the problem somehow? paulmillr/noble-hashes@412a108#diff-cc63f119b1879db255abe3dbb493232f19c026790a1514a05a135ef618fdaa23

mcmire · 2023-10-27T19:05:43Z

Okay, I managed to find the issue. It looks like there is a dependency update downstream. In addition to upgrading @metamask/scure-bip39, this PR also upgrades @noble/hashes from 1.1.5 to 1.3.2.

In @noble/hashes 1.1.5, @noble/hashes/crypto only supported Node. It returned an object { node, web }, where web always always undefined and node resolved to all of the imports from the crypto library. In 1.3.2, however, @noble/hashes/crypto supports either Node or web. It does this by accessing crypto from globalThis.

However, globalThis.crypto seems to be undefined in Jest tests. I believe this is due to long-standing behavior in Jest where globals need to be manually copied into the Node sandbox (jest-environment-node) that all tests are run in. A similar issue happened with the global fetch function which was patched in Jest 28, and I suspect the Jest team has not done the same thing for crypto.

That said, in the past we've encountered a similar problem with TextEncoder, ArrayBuffer, etc. in assets-controllers tests, and the way we solved it then was to make an extension of the JSDom environment where we manually insert the globals into the sandbox that we want to be available: https://github.com/MetaMask/core/blob/5ff1505aa4833f7b6c9055cc734c18be2401b661/packages/assets-controllers/jest.environment.js. We may be able to do a similar thing here, except for jest-environment-node instead of jest-environment-jsdom.

Another, simpler way we could solve this is to pop a jest.spyOn(globalThis, 'crypto') in a beforeEach at the top of KeyringController.test.ts and provide a mock implementation for getRandomValues.

legobeat · 2023-11-14T08:02:43Z

@dependabot recreate

dependabot · 2023-11-14T08:13:20Z

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

…-2.1.1

mcmire · 2023-11-15T18:47:19Z

packages/keyring-controller/jest.environment.js

+  async setup() {
+    await super.setup();
+    if (typeof this.global.crypto === 'undefined') {
+      this.global.crypto = require('crypto').webcrypto;


@noble/hashes will use Web Crypto API within a Node context. Specifically, this file will get loaded thanks to this line in package.json.

Unfortunately, that's not happening in the tests, and this file gets loaded instead, which attempts to read global.crypto instead of require('crypto').webcrypto. I'm not 100% sure on this, but I believe that's happening because of the way we've configured TypeScript: we're using a moduleResolution of node, i.e. "classic" mode, which means that TypeScript skips the "exports" field in package.json.

mcmire · 2023-11-15T18:47:44Z

Tests should work now!

…-2.1.1

dependabot bot requested a review from a team as a code owner October 19, 2023 12:19

dependabot bot added the dependencies Pull requests that update a dependency file label Oct 19, 2023

legobeat added 2 commits October 27, 2023 17:17

Merge branch main into dependabot/npm_and_yarn/metamask/scure-bip39-2…

d9e8263

….1.1

yarn dedupe

16af682

mcmire mentioned this pull request Oct 27, 2023

Bump @metamask/eth-keyring-controller from 13.0.1 to 14.0.0 #1771

Merged

mcmire added 3 commits November 15, 2023 11:05

Merge branch 'main' into dependabot/npm_and_yarn/metamask/scure-bip39…

2f3c7b7

…-2.1.1

Get keyring controller tests running again

28a50ba

Merge branch 'main' into dependabot/npm_and_yarn/metamask/scure-bip39…

ad05132

…-2.1.1

mcmire reviewed Nov 15, 2023

View reviewed changes

legobeat approved these changes Nov 15, 2023

View reviewed changes

Merge branch 'main' into dependabot/npm_and_yarn/metamask/scure-bip39…

2970e44

…-2.1.1

mcmire merged commit ee2c5cc into main Nov 15, 2023

mcmire deleted the dependabot/npm_and_yarn/metamask/scure-bip39-2.1.1 branch November 15, 2023 21:26

gantunesr mentioned this pull request Mar 6, 2024

refactor: migrate Encryptor to TypeScript and increase PBKDF2 iterations number MetaMask/metamask-mobile#8828

Closed

11 tasks

gantunesr mentioned this pull request Mar 28, 2024

refactor: migrate Encryptor to TypeScript and increase PBKDF2 iterations number MetaMask/metamask-mobile#9093

Merged

11 tasks

Uh oh!

Conversation

dependabot bot commented on behalf of github Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2.1.1

Added

Changed

[2.1.1]

Added

Changed

Uh oh!

dependabot bot commented on behalf of github Oct 19, 2023

Uh oh!

dependabot bot commented on behalf of github Oct 19, 2023

Uh oh!

dependabot bot commented on behalf of github Oct 20, 2023

Uh oh!

dependabot bot commented on behalf of github Oct 20, 2023

Uh oh!

dependabot bot commented on behalf of github Oct 20, 2023

Uh oh!

legobeat commented Oct 22, 2023

Uh oh!

dependabot bot commented on behalf of github Oct 23, 2023

Uh oh!

dependabot bot commented on behalf of github Oct 23, 2023

Uh oh!

dependabot bot commented on behalf of github Oct 23, 2023

Uh oh!

dependabot bot commented on behalf of github Oct 23, 2023

Uh oh!

dependabot bot commented on behalf of github Oct 24, 2023

Uh oh!

dependabot bot commented on behalf of github Oct 24, 2023

Uh oh!

dependabot bot commented on behalf of github Oct 24, 2023

Uh oh!

dependabot bot commented on behalf of github Oct 24, 2023

Uh oh!

dependabot bot commented on behalf of github Oct 24, 2023

Uh oh!

dependabot bot commented on behalf of github Oct 24, 2023

Uh oh!

dependabot bot commented on behalf of github Oct 24, 2023

Uh oh!

dependabot bot commented on behalf of github Oct 25, 2023

Uh oh!

legobeat commented Oct 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcmire commented Oct 27, 2023

Uh oh!

mcmire commented Oct 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcmire commented Oct 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

legobeat commented Nov 14, 2023

Uh oh!

dependabot bot commented on behalf of github Nov 14, 2023

Uh oh!

mcmire Nov 15, 2023

Choose a reason for hiding this comment

Uh oh!

mcmire commented Nov 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dependabot bot commented on behalf of github Oct 19, 2023 •

edited

Loading

legobeat commented Oct 27, 2023 •

edited

Loading

mcmire commented Oct 27, 2023 •

edited

Loading

mcmire commented Oct 27, 2023 •

edited

Loading