Explanation

Adds success and error methods to the ApprovalController to easily create standardised approvals to display success or error pages in the clients.

These methods both support optional arguments including message, error, and header to configure what text or components are displayed in the approval, plus flowToEnd which will end the specified flow when the result confirmation is approved.

This PR also includes some minor refactors for consistency, including:

• Replacing use of the private modifier with the # syntax to protect private properties and methods at runtime.
• Removing calls to any private methods from the unit tests.
• Grouping the many types into categories to simplify future additions.

Changelog

@metamask/approval-controller

• ADDED: success and error methods to display standardised result pages

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate