Enable token detection for the Aurora network#1327
Merged
dan437 merged 4 commits intoMetaMask:mainfrom May 8, 2023
dan437:token-detection-aurora
Merged
Enable token detection for the Aurora network#1327dan437 merged 4 commits intoMetaMask:mainfrom dan437:token-detection-aurora
dan437 merged 4 commits intoMetaMask:mainfrom
dan437:token-detection-aurora
Conversation
2 tasks
3 tasks
mcmire
reviewed
May 4, 2023
Contributor
mcmire
left a comment
There was a problem hiding this comment.
I see that we are making it so that isTokenDetectionSupportedForNetwork returns true for Aurora, but this assumes that we're using that function somewhere. Is there a way to prove that token detection works for Aurora? Perhaps we could copy this test: we could use Nock to mock the token API for Aurora so that it returns some tokens, configures the controller for Aurora, calls start, and confirms that Aurora is being hit and returns a set of tokens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable token detection for the Aurora network.