Skip to content

Remove duplicate hasProperty function#1275

Merged
Gudahtt merged 1 commit intomainfrom
remove-has-property
Apr 26, 2023
Merged

Remove duplicate hasProperty function#1275
Gudahtt merged 1 commit intomainfrom
remove-has-property

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Apr 26, 2023

Description

The hasProperty function in @metamask/controller-utils has been removed. Instead the hasProperty function from @metamask/utils is now used in its place. The @metamask/utils version of this function is functionally identical but has a better type signature.

Changes

  • BREAKING: Remove the hasProperty function

References

Relates to #1204

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

The `hasProperty` function in `@metamask/controller-utils` has been
removed. Instead the `hasProperty` function from `@metamask/utils` is
now used in its place. The `@metamask/utils` version of this function
is functionally identical but has a better type signature.

Relates to #1204
@Gudahtt Gudahtt marked this pull request as ready for review April 26, 2023 15:44
@Gudahtt Gudahtt requested a review from a team as a code owner April 26, 2023 15:44
Copy link
Copy Markdown
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit f70be43 into main Apr 26, 2023
@Gudahtt Gudahtt deleted the remove-has-property branch April 26, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants