Skip to content

json-rpc-middleware-stream: Incorrect notification handling #4308

@rekmarks

Description

@rekmarks

json-rpc-middleware-stream detects notifications by checking if response.id is falsy, when it should rather check if hasProperty(response, 'id') is false (source). This ensures that it will never hit this case in processResponse(), whose purpose and JSON-RPC spec compliance I am uncertain of.

Either way, we should detect notifications via the absence of the id property, and not whether its value is falsy.

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingteam-wallet-frameworkDeprecated: Please use `team-core-platform` instead.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions