-
-
Notifications
You must be signed in to change notification settings - Fork 277
Closed
Labels
bugSomething isn't workingSomething isn't workingteam-wallet-frameworkDeprecated: Please use `team-core-platform` instead.Deprecated: Please use `team-core-platform` instead.
Description
json-rpc-middleware-stream detects notifications by checking if response.id is falsy, when it should rather check if hasProperty(response, 'id') is false (source). This ensures that it will never hit this case in processResponse(), whose purpose and JSON-RPC spec compliance I am uncertain of.
Either way, we should detect notifications via the absence of the id property, and not whether its value is falsy.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingteam-wallet-frameworkDeprecated: Please use `team-core-platform` instead.Deprecated: Please use `team-core-platform` instead.