…wareMessenger` pattern, fix `any` (#1970) ## Explanation ### Apply controller-messenger pattern - Defines `QueuedRequestMiddlewareMessenger`, `SelectedNetworkMiddlewareMessenger` types to represent external controller messengers in the middleware chain. - Reserved for internal use and not exported at package level. - Defines separate allow lists for `QueuedRequest{Controller,Middleware}Messenger` and `SelectedNetwork{Controller,Middleware}Messenger`. ### Type fixes - Defines and exports `QueuedRequestMiddlewareJsonRpcRequest`, `SelectedNetworkMiddlewareJsonRpcRequest` types. - Fix `any` usage in `createSelectedNetworkMiddleware` ### Tests - Fixes `any`, `as any` usage in `QueuedRequestController`, `QueuedRequestMiddleware` tests. - Moves util functions for building test messengers into individual test files. - For context: #1970 (comment) ## References - Follow-up from #1806 - Builds on #2051 - Closes #2038 ## Changelog ### `@metamask/queued-request-controller` - **ADDED**: Add `QueuedRequestMiddlewareJsonRpcRequest` typee - **BREAKING:** `QueuedRequestControllerMessenger` can no longer be defined with any allowed actions or events. - **CHANGED**: Move `@metamask/approval-controller` from devDeps to deps. ### `@metamask/selected-network-controller` - **ADDED**: Add `SelectedNetworkMiddlewareJsonRpcRequest` type - **BREAKING:** Rename `SelectedNetworkControllerAction` to `SelectedNetworkControllerActions` and `SelectedNetworkControllerEvent` to `SelectedNetworkControllerEvents` for consistency with corresponding type exports from other controllers. - **BREAKING:** `createSelectedNetworkMiddleware` return type is constrained to satisfy `JsonRpcMiddleware<JsonRpcParams, Json>`, and the `req` parameter needs to satisfy `SelectedNetworkMiddlewareJsonRpcRequest`. ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>

Uh oh!

[queued-request-controller, selected-network-controller] Apply AllowedActions, MiddlewareMessenger patterns, fix any #2038

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

[queued-request-controller, selected-network-controller] Apply `AllowedActions`, `MiddlewareMessenger` patterns, fix `any` #2038