-
-
Notifications
You must be signed in to change notification settings - Fork 278
Align keyrings destroy / dispose API #1428
Copy link
Copy link
Open
Labels
Epicteam-wallet-frameworkDeprecated: Please use `team-core-platform` instead.Deprecated: Please use `team-core-platform` instead.wf-keyring
Description
Currently, the type we use for Keyrings does not include a "destroy" function. On the other hand, Ledger and Trezor keyring have a function for this and is named dispose for Trezor and destroy for Ledger.
At the moment Ledger and Trezor keyrings are not implementing the Keyring type, but would be beneficial to:
- Add the
destroymethod on Keyring type - Rename Trezor's
disposemethod todestroy - Trezor keyring should implement Keyring type
- Ledger keyring should implement Keyring type
See also original discussion: MetaMask/KeyringController#233 (comment)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Epicteam-wallet-frameworkDeprecated: Please use `team-core-platform` instead.Deprecated: Please use `team-core-platform` instead.wf-keyring