Skip to content

Align keyrings destroy / dispose API #1428

@mikesposito

Description

@mikesposito

Currently, the type we use for Keyrings does not include a "destroy" function. On the other hand, Ledger and Trezor keyring have a function for this and is named dispose for Trezor and destroy for Ledger.

At the moment Ledger and Trezor keyrings are not implementing the Keyring type, but would be beneficial to:

See also original discussion: MetaMask/KeyringController#233 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions