Recategorize controller dependencies as devDependencies if only imports are messaging system-related types (#3607)

MajorLift · web-flow · commit ca4baa00dfa1 · 2023-12-22T11:20:43.000-08:00
## Explanation - Controller dependencies that are used via the messaging system should be listed under `peerDependencies` to ensure that we see warnings for incompatible versions. - A `peerDependencies` controller that is not invoked directly at runtime shouldn't be included under `dependencies`. Any type imports will still resolve because we can assume the controller package will be installed. ## References ## Changelog ### `@metamask/accounts-controller` ### Fixed - Add `@metamask/snaps-controllers` as a peer dependency in addition to a dev dependency ([#3607](#3607)) ### `@metamask/ens-controller` ### Fixed - Recategorize `@metamask/network-controller` as a dev dependency and peer dependency ([#3607](#3607)) ### `@metamask/keyring-controller` ### Fixed - Recategorize `@metamask/preferences-controller` as a dev dependency and peer dependency ([#3607](#3607)) ### `@metamask/permission-controller` ### Fixed - Recategorize `@metamask/approval-controller` as a dev dependency and peer dependency ([#3607](#3607)) ### `@metamask/queued-request-controller` ### Fixed - Recategorize `@metamask/approval-controller`, `@metamask/network-controller`, `@metamask/selected-network-controller` as dev dependencies ([#3607](#3607)) ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
diff --git a/packages/accounts-controller/CHANGELOG.md b/packages/accounts-controller/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Fixed
+- Add `@metamask/snaps-controllers` as a peer dependency in addition to a dev dependency ([#3607](https://github.com/MetaMask/core/pull/3607))
 
 ## [6.0.0]
 ### Changed
diff --git a/packages/accounts-controller/package.json b/packages/accounts-controller/package.json
@@ -54,7 +54,8 @@
     "typescript": "~4.8.4"
   },
   "peerDependencies": {
-    "@metamask/keyring-controller": "^10.0.0"
+    "@metamask/keyring-controller": "^10.0.0",
+    "@metamask/snaps-controllers": "^3.2.0"
   },
   "engines": {
     "node": ">=16.0.0"
diff --git a/packages/ens-controller/CHANGELOG.md b/packages/ens-controller/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Fixed
+- Recategorize `@metamask/network-controller` as a dev dependency and peer dependency ([#3607](https://github.com/MetaMask/core/pull/3607))
 
 ## [7.0.0]
 ### Changed
diff --git a/packages/ens-controller/package.json b/packages/ens-controller/package.json
@@ -34,13 +34,13 @@
     "@ethersproject/providers": "^5.7.0",
     "@metamask/base-controller": "^4.0.0",
     "@metamask/controller-utils": "^8.0.0",
-    "@metamask/network-controller": "^17.0.0",
     "@metamask/utils": "^8.2.0",
     "ethereum-ens-network-map": "^1.0.2",
     "punycode": "^2.1.1"
   },
   "devDependencies": {
     "@metamask/auto-changelog": "^3.4.4",
+    "@metamask/network-controller": "^17.0.0",
     "@types/jest": "^27.4.1",
     "deepmerge": "^4.2.2",
     "jest": "^27.5.1",
diff --git a/packages/keyring-controller/CHANGELOG.md b/packages/keyring-controller/CHANGELOG.md
@@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 - Bump `@metamask/eth-keyring-controller` to `^15.1.0` ([#3617](https://github.com/MetaMask/core/pull/3617))
 
+### Fixed
+- Recategorize `@metamask/preferences-controller` as a dev dependency and peer dependency ([#3607](https://github.com/MetaMask/core/pull/3607))
+
 ## [10.0.0]
 ### Changed
 - **BREAKING:** Bump `@metamask/base-controller` to ^4.0.0 ([#2063](https://github.com/MetaMask/core/pull/2063))
diff --git a/packages/keyring-controller/package.json b/packages/keyring-controller/package.json
@@ -35,7 +35,6 @@
     "@metamask/base-controller": "^4.0.0",
     "@metamask/eth-keyring-controller": "^15.1.0",
     "@metamask/message-manager": "^7.3.6",
-    "@metamask/preferences-controller": "^5.0.0",
     "@metamask/utils": "^8.2.0",
     "async-mutex": "^0.2.6",
     "ethereumjs-util": "^7.0.10",
@@ -48,6 +47,7 @@
     "@keystonehq/bc-ur-registry-eth": "^0.9.0",
     "@metamask/auto-changelog": "^3.4.4",
     "@metamask/eth-sig-util": "^7.0.1",
+    "@metamask/preferences-controller": "^5.0.0",
     "@metamask/scure-bip39": "^2.1.1",
     "@types/jest": "^27.4.1",
     "deepmerge": "^4.2.2",
diff --git a/packages/permission-controller/CHANGELOG.md b/packages/permission-controller/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Fixed
+- Recategorize `@metamask/approval-controller` as a dev dependency and peer dependency ([#3607](https://github.com/MetaMask/core/pull/3607))
 
 ## [6.0.0]
 ### Added
diff --git a/packages/permission-controller/package.json b/packages/permission-controller/package.json
@@ -31,7 +31,6 @@
     "test:watch": "jest --watch"
   },
   "dependencies": {
-    "@metamask/approval-controller": "^5.1.0",
     "@metamask/base-controller": "^4.0.0",
     "@metamask/controller-utils": "^8.0.0",
     "@metamask/json-rpc-engine": "^7.3.0",
@@ -43,6 +42,7 @@
     "nanoid": "^3.1.31"
   },
   "devDependencies": {
+    "@metamask/approval-controller": "^5.1.0",
     "@metamask/auto-changelog": "^3.4.4",
     "@types/jest": "^27.4.1",
     "deepmerge": "^4.2.2",
diff --git a/packages/queued-request-controller/CHANGELOG.md b/packages/queued-request-controller/CHANGELOG.md
@@ -12,6 +12,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - **BREAKING:** `QueuedRequestControllerMessenger` can no longer be defined with any allowed actions or events ([#1970](https://github.com/MetaMask/core/pull/1970)).
 - Move `@metamask/approval-controller` from devDependency to dependency ([#1970](https://github.com/MetaMask/core/pull/1970)).
 
+### Fixed
+- Recategorize `@metamask/approval-controller`, `@metamask/network-controller`, `@metamask/selected-network-controller` as dev dependencies ([#3607](https://github.com/MetaMask/core/pull/3607))
+
 ## [0.2.0]
 ### Changed
 - **BREAKING:** Bump `@metamask/base-controller` to ^4.0.0 ([#2063](https://github.com/MetaMask/core/pull/2063))
diff --git a/packages/queued-request-controller/package.json b/packages/queued-request-controller/package.json
@@ -31,18 +31,18 @@
     "test:watch": "jest --watch"
   },
   "dependencies": {
-    "@metamask/approval-controller": "^5.1.0",
     "@metamask/base-controller": "^4.0.0",
     "@metamask/controller-utils": "^8.0.0",
     "@metamask/json-rpc-engine": "^7.3.0",
-    "@metamask/network-controller": "^17.0.0",
     "@metamask/rpc-errors": "^6.1.0",
-    "@metamask/selected-network-controller": "^5.0.0",
     "@metamask/swappable-obj-proxy": "^2.1.0",
     "@metamask/utils": "^8.2.0"
   },
   "devDependencies": {
+    "@metamask/approval-controller": "^5.1.0",
     "@metamask/auto-changelog": "^3.4.4",
+    "@metamask/network-controller": "^17.0.0",
+    "@metamask/selected-network-controller": "^5.0.0",
     "@types/jest": "^27.4.1",
     "deepmerge": "^4.2.2",
     "immer": "^9.0.6",
diff --git a/yarn.lock b/yarn.lock
@@ -1493,6 +1493,7 @@ __metadata:
     uuid: ^8.3.2
   peerDependencies:
     "@metamask/keyring-controller": ^10.0.0
+    "@metamask/snaps-controllers": ^3.2.0
   languageName: unknown
   linkType: soft
 
