Merge branch '230113-consolidate-TokenDetectionController-DetectTokensController' into 231220-TokensController-v2-migration

MajorLift · MajorLift · commit a3863017c058 · 2024-02-08T13:09:06.000-05:00
diff --git a/constraints.pro b/constraints.pro
@@ -396,10 +396,3 @@ gen_enforced_field(WorkspaceCwd, 'publishConfig.registry', 'https://registry.npm
 % whatsoever.
 gen_enforced_field(WorkspaceCwd, 'publishConfig', null) :-
   workspace_field(WorkspaceCwd, 'private', true).
-
-% eth-method-registry has an unlisted dependency on babel-runtime (via `ethjs->ethjs-query`), so
-% that package needs to be present if eth-method-registry is present.
-gen_enforced_dependency(WorkspaceCwd, 'babel-runtime', '^6.26.0', 'peerDependencies') :-
-  workspace_has_dependency(WorkspaceCwd, 'eth-method-registry', _, 'dependencies').
-gen_enforced_dependency(WorkspaceCwd, 'babel-runtime', '^6.26.0', 'devDependencies') :-
-  workspace_has_dependency(WorkspaceCwd, 'eth-method-registry', _, 'dependencies').
diff --git a/packages/assets-controllers/package.json b/packages/assets-controllers/package.json
@@ -60,7 +60,7 @@
   },
   "devDependencies": {
     "@metamask/auto-changelog": "^3.4.4",
-    "@metamask/ethjs-provider-http": "^0.2.0",
+    "@metamask/ethjs-provider-http": "^0.3.0",
     "@metamask/keyring-api": "^3.0.0",
     "@types/jest": "^27.4.1",
     "@types/lodash": "^4.14.191",
diff --git a/packages/controller-utils/package.json b/packages/controller-utils/package.json
@@ -32,7 +32,7 @@
   },
   "dependencies": {
     "@metamask/eth-query": "^4.0.0",
-    "@metamask/ethjs-unit": "^0.2.1",
+    "@metamask/ethjs-unit": "^0.3.0",
     "@metamask/utils": "^8.3.0",
     "@spruceid/siwe-parser": "1.1.3",
     "eth-ens-namehash": "^2.0.8",
diff --git a/packages/gas-fee-controller/package.json b/packages/gas-fee-controller/package.json
@@ -34,7 +34,7 @@
     "@metamask/base-controller": "^4.1.1",
     "@metamask/controller-utils": "^8.0.2",
     "@metamask/eth-query": "^4.0.0",
-    "@metamask/ethjs-unit": "^0.2.1",
+    "@metamask/ethjs-unit": "^0.3.0",
     "@metamask/network-controller": "^17.2.0",
     "@metamask/polling-controller": "^5.0.0",
     "@metamask/utils": "^8.3.0",
diff --git a/packages/selected-network-controller/src/SelectedNetworkController.ts b/packages/selected-network-controller/src/SelectedNetworkController.ts
@@ -192,9 +192,9 @@ export class SelectedNetworkController extends BaseController<
     this.#setNetworkClientIdForDomain(domain, networkClientId);
   }
 
-  getNetworkClientIdForDomain(domain: Domain) {
+  getNetworkClientIdForDomain(domain: Domain): NetworkClientId {
     if (this.state.perDomainNetwork) {
-      return this.state.domains[domain];
+      return this.state.domains[domain] ?? this.state.domains[METAMASK_DOMAIN];
     }
     return this.state.domains[METAMASK_DOMAIN];
   }
diff --git a/packages/selected-network-controller/tests/SelectedNetworkController.test.ts b/packages/selected-network-controller/tests/SelectedNetworkController.test.ts
@@ -205,6 +205,18 @@ describe('SelectedNetworkController', () => {
       expect(result1).toBe(networkClientId1);
       expect(result2).toBe(networkClientId2);
     });
+
+    it('returns the networkClientId for the metamask domain, when the perDomainNetwork option is true, but no networkClientId has been set for the domain requested', () => {
+      const options: SelectedNetworkControllerOptions = {
+        messenger: buildSelectedNetworkControllerMessenger(),
+      };
+      const controller = new SelectedNetworkController(options);
+      controller.state.perDomainNetwork = true;
+      const networkClientId = 'network7';
+      controller.setNetworkClientIdForMetamask(networkClientId);
+      const result = controller.getNetworkClientIdForDomain('example.com');
+      expect(result).toBe(networkClientId);
+    });
   });
 
   describe('getProviderAndBlockTracker', () => {
diff --git a/packages/transaction-controller/package.json b/packages/transaction-controller/package.json
@@ -44,19 +44,19 @@
     "@metamask/rpc-errors": "^6.1.0",
     "@metamask/utils": "^8.3.0",
     "async-mutex": "^0.2.6",
-    "eth-method-registry": "^3.0.0",
+    "eth-method-registry": "^4.0.0",
     "ethereumjs-util": "^7.0.10",
     "fast-json-patch": "^3.1.1",
     "lodash": "^4.17.21",
     "nonce-tracker": "^3.0.0",
     "uuid": "^8.3.2"
   },
   "devDependencies": {
+    "@babel/runtime": "^7.23.9",
     "@metamask/auto-changelog": "^3.4.4",
-    "@metamask/ethjs-provider-http": "^0.2.0",
+    "@metamask/ethjs-provider-http": "^0.3.0",
     "@types/jest": "^27.4.1",
     "@types/node": "^16.18.54",
-    "babel-runtime": "^6.26.0",
     "deepmerge": "^4.2.2",
     "jest": "^27.5.1",
     "sinon": "^9.2.4",
@@ -66,10 +66,10 @@
     "typescript": "~4.8.4"
   },
   "peerDependencies": {
+    "@babel/runtime": "^7.23.9",
     "@metamask/approval-controller": "^5.1.2",
     "@metamask/gas-fee-controller": "^13.0.0",
-    "@metamask/network-controller": "^17.2.0",
-    "babel-runtime": "^6.26.0"
+    "@metamask/network-controller": "^17.2.0"
   },
   "engines": {
     "node": ">=16.0.0"
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -192,9 +192,9 @@ export class SelectedNetworkController extends BaseController<`
`192`	`192`	`this.#setNetworkClientIdForDomain(domain, networkClientId);`
`193`	`193`	`}`
`194`	`194`
`195`		`- getNetworkClientIdForDomain(domain: Domain) {`
	`195`	`+ getNetworkClientIdForDomain(domain: Domain): NetworkClientId {`
`196`	`196`	`if (this.state.perDomainNetwork) {`
`197`		`- return this.state.domains[domain];`
	`197`	`+ return this.state.domains[domain] ?? this.state.domains[METAMASK_DOMAIN];`
`198`	`198`	`}`
`199`	`199`	`return this.state.domains[METAMASK_DOMAIN];`
`200`	`200`	`}`