test: Write unit tests for isSafeDynamicKey validation

MajorLift · MajorLift · commit a145237447a8 · 2024-03-14T13:01:19.000-04:00
diff --git a/packages/address-book-controller/src/AddressBookController.test.ts b/packages/address-book-controller/src/AddressBookController.test.ts
@@ -294,6 +294,13 @@ describe('AddressBookController', () => {
     ).toBe(true);
   });
 
+  it('should return false to indicate an address book entry has NOT been deleted due to unsafe input', () => {
+    const controller = new AddressBookController();
+    // @ts-expect-error Suppressing error to test runtime behavior
+    expect(controller.delete('__proto__', '0x01')).toBe(false);
+    expect(controller.delete(toHex(1), 'constructor')).toBe(false);
+  });
+
   it('should return false to indicate an address book entry has NOT been deleted', () => {
     const controller = new AddressBookController();
     controller.set('0x32Be343B94f860124dC4fEe278FDCBD38C102D88', '0x00');
diff --git a/packages/ens-controller/src/EnsController.test.ts b/packages/ens-controller/src/EnsController.test.ts
@@ -359,6 +359,16 @@ describe('EnsController', () => {
     expect(controller.state.ensEntries['0x1']).toBeUndefined();
   });
 
+  it('should return false if an ENS entry was NOT deleted due to unsafe input', () => {
+    const messenger = getMessenger();
+    const controller = new EnsController({
+      messenger,
+    });
+    // @ts-expect-error Suppressing error to test runtime behavior
+    expect(controller.delete('__proto__', 'bar')).toBe(false);
+    expect(controller.delete(toHex(2), 'constructor')).toBe(false);
+  });
+
   it('should return false if an ENS entry was NOT deleted', () => {
     const messenger = getMessenger();
     const controller = new EnsController({
diff --git a/packages/name-controller/jest.config.js b/packages/name-controller/jest.config.js
@@ -17,10 +17,10 @@ module.exports = merge(baseConfig, {
   // An object that configures minimum threshold enforcement for coverage results
   coverageThreshold: {
     global: {
-      branches: 99.15,
+      branches: 100,
       functions: 100,
-      lines: 99.72,
-      statements: 99.72,
+      lines: 100,
+      statements: 100,
     },
   },
 });
diff --git a/packages/name-controller/src/NameController.test.ts b/packages/name-controller/src/NameController.test.ts
@@ -458,6 +458,64 @@ describe('NameController', () => {
       });
     });
 
+    it('does not update if passed unsafe input', () => {
+      const provider1 = createMockProvider(1);
+
+      const controller = new NameController({
+        ...CONTROLLER_ARGS_MOCK,
+        providers: [provider1],
+        state: {
+          names: {
+            [NameType.ETHEREUM_ADDRESS]: {
+              [VALUE_MOCK]: {
+                [CHAIN_ID_MOCK]: {
+                  name: null,
+                  sourceId: null,
+                  origin: null,
+                  proposedNames: {
+                    [SOURCE_ID_MOCK]: {
+                      proposedNames: [PROPOSED_NAME_MOCK, PROPOSED_NAME_2_MOCK],
+                      lastRequestTime: null,
+                      updateDelay: null,
+                    },
+                  },
+                },
+              },
+            },
+          },
+        },
+      });
+
+      controller.setName({
+        value: '__proto__',
+        type: NameType.ETHEREUM_ADDRESS,
+        name: NAME_MOCK,
+        sourceId: `${SOURCE_ID_MOCK}1`,
+        variation: CHAIN_ID_MOCK,
+      });
+
+      expect(controller.state.names).toStrictEqual<
+        NameControllerState['names']
+      >({
+        [NameType.ETHEREUM_ADDRESS]: {
+          [VALUE_MOCK]: {
+            [CHAIN_ID_MOCK]: {
+              name: null,
+              sourceId: null,
+              origin: null,
+              proposedNames: {
+                [SOURCE_ID_MOCK]: {
+                  proposedNames: [PROPOSED_NAME_MOCK, PROPOSED_NAME_2_MOCK],
+                  lastRequestTime: null,
+                  updateDelay: null,
+                },
+              },
+            },
+          },
+        },
+      });
+    });
+
     it('does not throw if variation is fallback and type is Ethereum address', () => {
       const controller = new NameController(CONTROLLER_ARGS_MOCK);
 
