Conversation
f8d8310 to
ecf59b1
Compare
infer, :, as, any)8c2fbe0 to
b4511bc
Compare
d5c1704 to
c5a59b8
Compare
c5a59b8 to
b9644ca
Compare
adbe5ca to
513a52a
Compare
4c8fb5c to
44d575c
Compare
44d575c to
39795dc
Compare
69a0989 to
b1385fc
Compare
mcmire
approved these changes
Apr 25, 2024
Contributor
mcmire
left a comment
There was a problem hiding this comment.
Lots of good stuff to chew on here! I skimmed through it one more time. This gets me thinking that it may be valuable to have two different kinds of documents in the future, one that's purely "do"s and "don't"s, and another that is a bit more expositional. We can decide on that in the future though. Nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In order to improve type safety and maintainability, we need to establish clear guidelines regarding how to apply types: specifically, when and when not to use explicit type declarations or keywords such as
as,any.Explanation
The merge conflicts with main will be resolved after the review process to avoid noisy diffs.Table of Contents
:,satisfies)as,!)any,@ts-expect-error)Details
References
any,asusage in TypeScript Guidelines doc #47