fix: fix stretched uma logo to round#1185
Merged
MRabenda merged 1 commit intoMetaMask:masterfrom May 7, 2023
Merged
Conversation
Signed-off-by: david <david@umaproject.org>
MRabenda
approved these changes
May 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
motivation
UMA tokens show up in metamask with an incorrect icon:
This bug was introduced wtih this pr during what looks like a refactor to move from pngs to svgs.
the previous icon looked like this:
https://github.com/MetaMask/contract-metadata/blob/559fff65171dfbd312fa5456937f9b75c862c6b9/images/UMA.png
after the pr, it turned into a rectangle, which is what is causing the icon to render icorrectly
https://github.com/MetaMask/contract-metadata/blob/199b28f1764e73356bae52d18b8fe6037cc7f800/images/uma.svg
changes
I've discussed with our deisgner as to how he would like the token icon to look. this pr proposes an updated UMA token logo as an svg.
preview: