Fixing SVG icon for sETH and sUSD token#1050
Merged
MRabenda merged 2 commits intoMetaMask:masterfrom Jul 6, 2022
Merged
Conversation
MRabenda
approved these changes
Jul 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes token icon for sETH and sUSD.
An SVG XML should contain the ns information according to SVG standard here: https://www.w3.org/TR/SVG11/struct.html#NewDocumentOverview, which is saying:
Without this, the svg could not be recognized by some parsers and renderers, which might be problematic
Also I suggest we add some CI checks to make sure SVG icons are standard compliant