Skip to content

Add Quid Ika Token#1043

Merged
MRabenda merged 7 commits intoMetaMask:masterfrom
quidverse:quidika
Aug 11, 2022
Merged

Add Quid Ika Token#1043
MRabenda merged 7 commits intoMetaMask:masterfrom
quidverse:quidika

Conversation

@ShailChoksi
Copy link
Copy Markdown
Contributor

@ShailChoksi ShailChoksi commented May 7, 2022

@ShailChoksi ShailChoksi requested review from a team and MRabenda as code owners May 7, 2022 05:39
MRabenda
MRabenda reviewed May 9, 2022
View reviewed changes
@ShailChoksi
Copy link
Copy Markdown
Contributor Author

ShailChoksi commented May 12, 2022

@MRabenda bump?

@ShailChoksi
Copy link
Copy Markdown
Contributor Author

ShailChoksi commented May 18, 2022

Am I still missing something here?

@ShailChoksi
Copy link
Copy Markdown
Contributor Author

ShailChoksi commented Jul 25, 2022

@MRabenda updated

@MRabenda
Copy link
Copy Markdown
Collaborator

MRabenda commented Jul 26, 2022

  1. Please remove PNG from PR
  2. Your SVG has ~ 800kb regular one should have < 10 - can you improve it?

@ShailChoksi
Copy link
Copy Markdown
Contributor Author

ShailChoksi commented Jul 26, 2022

  1. Please remove PNG from PR
  2. Your SVG has ~ 800kb regular one should have < 10 - can you improve it?
  1. Done
  2. I am not too familiar with SVGs so I am not able to get it much smaller before starting to lose details on the image. I cut it down to about 50% of the original.

@MRabenda
Copy link
Copy Markdown
Collaborator

MRabenda commented Jul 28, 2022

From what I can see on Etherescan and Coinmarket cap Quid Ika has a different icon that this gray used here

@ShailChoksi
Copy link
Copy Markdown
Contributor Author

ShailChoksi commented Jul 28, 2022

From what I can see on Etherescan and Coinmarket cap Quid Ika has a different icon that this gray used here

We have been rebranding. It takes time for CMC and Etherscan to update. Our Telegram, Discord and Dextools all have the new symbol/logo.

@ShailChoksi
Copy link
Copy Markdown
Contributor Author

ShailChoksi commented Jul 29, 2022

@MRabenda let me know if you need more info or need me to prove that this is the new logo for the token

@ShailChoksi
Copy link
Copy Markdown
Contributor Author

ShailChoksi commented Aug 2, 2022

Bump @MRabenda

@ShailChoksi
Copy link
Copy Markdown
Contributor Author

ShailChoksi commented Aug 10, 2022

@MRabenda bump?

@MRabenda MRabenda merged commit 2b9473b into MetaMask:master Aug 11, 2022
@ShailChoksi ShailChoksi deleted the quidika branch September 21, 2022 18:33
@ShailChoksi
Copy link
Copy Markdown
Contributor Author

ShailChoksi commented Sep 21, 2022

How long does it take for this to show up in the app?

@ShailChoksi ShailChoksi mentioned this pull request Sep 21, 2022
Closed
@MRabenda
Copy link
Copy Markdown
Collaborator

MRabenda commented Mar 21, 2023

@ShailChoksi - QUID token has 18 or 9 decimals https://etherscan.io/address/0x9d38f670d15c14716be1f109a4f453e966a2b6d4#readContract ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MRabenda MRabenda MRabenda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShailChoksi @MRabenda