Skip to content

BREAKING: Increase minimum Node.js version to 16; recommended to 18#52

Merged
legobeat merged 1 commit intoMetaMask:mainfrom
legobeat:node-16
Nov 29, 2023
Merged

BREAKING: Increase minimum Node.js version to 16; recommended to 18#52
legobeat merged 1 commit intoMetaMask:mainfrom
legobeat:node-16

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Nov 14, 2023

  • BREAKING: remove support for major node versions 14-15,17,19
    • ci: run on node v20 instead of v14
    • set .nvmrc to v18 (thereby changing default ci node version)
    • docs: change recommended node version from v14 to v18

@legobeat legobeat marked this pull request as ready for review November 14, 2023 13:07
@legobeat legobeat requested review from a team as code owners November 14, 2023 13:07
Copy link
Copy Markdown

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

- ci: run on node 20 instead of 14
- remove support for major node versions 14-15,17,19
- set .nvmrc to v18 (thereby changing default ci node version)
@legobeat legobeat merged commit d6157bc into MetaMask:main Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants