fix: allow category extraction when scope is used#240
Merged
NicolasMassart merged 3 commits intomainfrom Apr 29, 2025
Merged
Conversation
MajorLift
reviewed
Apr 25, 2025
MajorLift
reviewed
Apr 25, 2025
MajorLift
reviewed
Apr 25, 2025
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
MajorLift
approved these changes
Apr 25, 2025
MajorLift
previously requested changes
Apr 25, 2025
Contributor
MajorLift
left a comment
There was a problem hiding this comment.
We should get codeowner approval from @MetaMask/wallet-framework-engineers
MajorLift
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the category extraction to use a RegExp to matches Conventional Commits that start with
feat:orfix:(optionally with a scope likefeat(scope):).Regex breakdown
^– Start of the string(feat|fix)– Must start with eitherfeatorfix(?:\([^)]*\))?– Optionally match a scope in parentheses like(bridge)or(ramps)\s*:\s*– Requires a colon:(with optional spaces before/after)/u– Unicode flag (as GitHub allows PR titles to contain unicode)See https://consensys.slack.com/archives/C08N7NQRBPU/p1745578034343929