This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Validate seed across all wordlists#77
Merged
Gudahtt merged 3 commits intoMetaMask:mainfrom Jan 4, 2022
hladik-dan:master
Merged
Validate seed across all wordlists#77Gudahtt merged 3 commits intoMetaMask:mainfrom hladik-dan:master
Gudahtt merged 3 commits intoMetaMask:mainfrom
hladik-dan:master
Conversation
Rose2161
previously approved these changes
May 16, 2021
Contributor
Author
|
@Rose2161 Can you review this PR again please? |
Rose2161
approved these changes
Dec 30, 2021
Rose2161
previously approved these changes
Dec 30, 2021
Member
|
Thanks for the contribution! This looks good once the lint error has been fixed. |
Contributor
Author
|
@Gudahtt Fixed via |
Merged
2 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes allow to use seed from any BIP39 wordlist.
In order to spread adoption even further I think that we should allow to use words from all BIP39 wordlist languages.