This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Merged
Conversation
697d648 to
bc455f9
Compare
bc455f9 to
d5ccee9
Compare
montelaidev
approved these changes
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a warning on the main README, to inform package users and devs that EthKeyringController has been moved to the core monorepo, and merged into KeyringController.
Because of that, PRs will no longer be accepted, with the exception of security patches.
Changes
No functional changes
References
EthKeyringControlleras in Maintenance core#3768Checklist