This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Conversation
3 tasks
mikesposito
previously approved these changes
Jul 18, 2023
Member
mikesposito
left a comment
There was a problem hiding this comment.
Looks good, I just left a couple of notes
Each test now uses a helper function to construct the keyring controller rather than using `beforeEach`. This eliminates redundant redundancy in cases where the controller was being overwritten, and makes it easier for future tests to customize how the controller is initialized.
Member
Author
|
Rebased to resolve conflicts |
mikesposito
approved these changes
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Each test now uses a helper function to construct the keyring controller rather than using
beforeEach. This eliminates redundant redundancy in cases where the controller was being overwritten, and makes it easier for future tests to customize how the controller is initialized.Changes
None
References
N/A
Checklist