This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Update utils package and rename dispose fn#234
Merged
mikesposito merged 2 commits intomainfrom Jul 4, 2023
Merged
Conversation
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
Gudahtt
suggested changes
Jun 21, 2023
Member
Gudahtt
left a comment
There was a problem hiding this comment.
I think we need to bump the minimum Node.js version first, this package still supports v14
b92612c to
4e4bbd5
Compare
Gudahtt
reviewed
Jul 4, 2023
| "packageManager": "yarn@3.2.1", | ||
| "engines": { | ||
| "node": ">=14.0.0" | ||
| "node": ">=16.0.0" |
Member
There was a problem hiding this comment.
Thoughts on moving this to a separate PR? It would be easier to keep track of that way
Member
Author
There was a problem hiding this comment.
Yes, I think it would be better to separate the scopes into two PRs
I created 236, that we could merge before this PR
4e4bbd5 to
c02b085
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR pulls the latest version of
@metamask/utils, which also includes an updatedKeyringtype with an optionaldestroymethod: this allows us to remove some type narrowing and the ambiguity betweendisposeanddestroymethods.Changes
disposeoptional method is not called anymore when destroying a keyringChecklist