This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Merged
Conversation
danroc
approved these changes
Apr 19, 2023
Gudahtt
approved these changes
Apr 19, 2023
Comment on lines
+1039
to
+1041
| // @ts-expect-error The method 'init' is not part of the current Keyring type | ||
| if (keyring.init) { | ||
| // @ts-expect-error The method 'init' is not part of the current Keyring type |
Member
There was a problem hiding this comment.
Nit: We can check for this function in a way that TypeScript understands, rather than suppress the error:
Suggested change
| // @ts-expect-error The method 'init' is not part of the current Keyring type | |
| if (keyring.init) { | |
| // @ts-expect-error The method 'init' is not part of the current Keyring type | |
| if (hasProperty(keyring, 'init') && typeof keyring.init === 'function') { |
The hasProperty function used here would have to be imported, but it's in @metamask/utils which is already a dependency.
Member
Author
There was a problem hiding this comment.
I'll open another PR to include your suggestion @Gudahtt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a false positive in the current CI caused by using
TypeScript v.5.0.2andts-jest v29.0.3. This development updates it to the required version and ignores the error in the meanwhile.The PR MetaMask/utils#99 should solve the root cause of the TS error.