This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Conversation
5af3f57 to
b8be87d
Compare
5282555 to
25d0885
Compare
mcmire
reviewed
Dec 15, 2022
The ESLint config has been updated to v11, and all lint-related packages have been updated. Most changes were fixed using `yarn lint:fix`. A manual change was needed to ignore the error for use of the `in` operator, and to ignore the lint warning for the use of the `events` API. A note was added to the README to explain that the `events` API is used. The `lint:misc` script was updated to include a new flag, to better match the module template.
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
42722fb to
99db463
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ESLint config has been updated to v11, and all lint-related packages have been updated.
Most changes were fixed using
yarn lint:fix. A manual change was needed to remove use of theinoperator, and to ignore the lint warning for the use of theeventsAPI. A note was added to the README to explain that theeventsAPI is used.The
lint:miscscript was updated to include a new flag, to better match the module template.