fix: correct inverted error check in getTunnelName#2659
Merged
wwqgtxx merged 1 commit intoMar 31, 2026
Conversation
The condition `err != nil` should be `err == nil`. The current code assigns tunName from getTunnelName only when the call fails, discarding the correct tunnel name on success. This causes incorrect forwarderBindInterface behavior when FileDescriptor > 0. Fixes MetaCubeX#2658 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
err != nil→err == nil) inlistener/sing_tun/server.go:158tunNamefromgetTunnelNameonly when the call fails, discarding the correct tunnel name on successforwarderBindInterfacebehavior whenFileDescriptor > 0(Android/iOS scenarios)Change
Test plan
FileDescriptor > 0tunNameis correctly set from the fd-based interface nameforwarderBindInterfaceistrueonly whengetTunnelNamesucceedsFixes #2658
🤖 Generated with Claude Code