Use HasPrefix instead of Contains for key checks#2447
Merged
wwqgtxx merged 1 commit intoMetaCubeX:Alphafrom Dec 19, 2025
Merged
Use HasPrefix instead of Contains for key checks#2447wwqgtxx merged 1 commit intoMetaCubeX:Alphafrom
wwqgtxx merged 1 commit intoMetaCubeX:Alphafrom
Conversation
Replaced strings.Contains with strings.HasPrefix when checking for 'geosite:' and 'rule-set:' prefixes in config parsing functions. This ensures more accurate matching and prevents false positives when these substrings appear elsewhere in the key.
There was a problem hiding this comment.
Pull request overview
This PR improves the accuracy of prefix matching in configuration parsing by replacing strings.Contains with strings.HasPrefix when checking for 'geosite:', 'rule-set:', and 'geoip:' prefixes. This ensures more precise matching and prevents false positives when these substrings appear anywhere else within the key string.
Key Changes:
- Updated prefix checks in
parseNameServerPolicyto useHasPrefixfor 'geosite:' and 'rule-set:' prefixes - Updated prefix checks in
parseIPCIDRto useHasPrefixfor 'geoip:' and 'rule-set:' prefixes - Updated prefix checks in
parseDomainto useHasPrefixfor 'geosite:' and 'rule-set:' prefixes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced strings.Contains with strings.HasPrefix when checking for 'geosite:' and 'rule-set:' prefixes in config parsing functions. This ensures more accurate matching and prevents false positives when these substrings appear elsewhere in the key.