Skip to content

update. add xvp rotation,new header generation strategy#2437

Merged
wwqgtxx merged 1 commit intoMetaCubeX:Alphafrom
saba-futai:Alpha
Dec 16, 2025
Merged

update. add xvp rotation,new header generation strategy#2437
wwqgtxx merged 1 commit intoMetaCubeX:Alphafrom
saba-futai:Alpha

Conversation

@saba-futai
Copy link

@wwqgtxx
Copy link
Collaborator

wwqgtxx commented Dec 15, 2025

If the current sudoku still requires copying so much identical/similar code between external libraries and internal libraries, why not simply put all related content into the transport/sudoku directory?

The current dependency on the official sudoku repository is confusing, relying on a special tag version outside the main branch, while there's a lot of duplicate code on both sides.

@saba-futai
Copy link
Author

In simple terms, the special tag differs from the main branch only in terms of go mod. It can also be considered akin to the difference between the dev branch and the stable branch—one is version 1.20 and the other is 1.24. This setup is meant to meet the requirements of mihomo. Additionally, I need to think about how to split and merge the packages for the complete porting work, so please merge this pull request first

@wwqgtxx
Copy link
Collaborator

wwqgtxx commented Dec 16, 2025

Indeed, we will merge that PR.

However, I feel that continuing like this will make subsequent maintenance increasingly difficult, and we need to resolve these issues as soon as possible.

@wwqgtxx wwqgtxx merged commit a06097c into MetaCubeX:Alpha Dec 16, 2025
@saba-futai
Copy link
Author

i will, thx a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants