fix: compare authentication scheme case-insensitively#2386
Merged
wwqgtxx merged 2 commits intoMetaCubeX:Alphafrom Nov 23, 2025
Merged
fix: compare authentication scheme case-insensitively#2386wwqgtxx merged 2 commits intoMetaCubeX:Alphafrom
wwqgtxx merged 2 commits intoMetaCubeX:Alphafrom
Conversation
Refactor parseBasicProxyAuthorization to use a constant for the prefix and improve case-insensitivity handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to RFC7617, the scheme should be case-insensitive. In practice, some implementations do use different case styles (example in ureq), causing authentication to fail.