Skip type collection if property has MessagePackFormatterAttribute#1462
Merged
AArnott merged 1 commit intoMessagePack-CSharp:masterfrom Jul 23, 2022
gllebede-havok:user/gllebede/skip_properties_with_MessagePackFormatterAttribute
Merged
Skip type collection if property has MessagePackFormatterAttribute#1462AArnott merged 1 commit intoMessagePack-CSharp:masterfrom gllebede-havok:user/gllebede/skip_properties_with_MessagePackFormatterAttribute
AArnott merged 1 commit intoMessagePack-CSharp:masterfrom
gllebede-havok:user/gllebede/skip_properties_with_MessagePackFormatterAttribute
Conversation
AArnott
approved these changes
Jun 29, 2022
Collaborator
AArnott
left a comment
There was a problem hiding this comment.
Looks safe enough. I gather the intended behavioral change is to respect the attribute where we didn't before? Or is this really just a perf optimization?
Contributor
Author
It's a fix for a bug. A property can define a MessagePackFormatter for a property so, from my understanding, it should use the type in the property. Instead, it tries to generate a formatter for property return type which may not be possible. |
This was referenced Oct 26, 2025
This was referenced Dec 2, 2025
This was referenced Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MessagePackFormatterAttribute defines a custom formatter so there is no reason to handle it automatically.