MessagePack.Generator RollForward to Major#1445
Conversation
|
This comes because our last stable release still targets .NET 5.0, which is no longer supported by Microsoft. We really should ship a stable release that targets a supported runtime (.NET 6.0). The develop branch already adds net6.0 support. How do you feel about us releasing 2.4 as a stable release? We could also merge this, but I get a bit anxious about such a setting because .NET major versions include breaking changes. I'd kinda like to ship on a runtime we've tested, and have things like this prompt us to upgrade. .NET 6 will be around till Nov 2024, so adding .NET 6 support will take care of this problem for a long time. |
|
Also, I wonder if your change actually does anything. I just tried packing the tool with your change, and I don't see that setting anywhere in the package. |
|
Yes, I agree with making 2.4 STABLE. However, these problems are repeated with the release of .NET 7 and with the release of .NET 8. It seems that there are not a few instances of encountering such problems and setting Major. I want that when .NET 7 is released, mpc will be in a state where it will work without updates in an environment where only .NET 7 is installed. |
|
For example, after the release of .NET 7, if a developer sets up a development environment on a new machine and installs only .NET 7 SDK, MessagePack.Generator (mpc) cannot be used unless it is targeting Of course, it is preferable to keep the targets updated, but I expect that it will be difficult to release projects in time for the release of .NET. While I can understand the compatibility concerns, but as a user it would be nice to have a way to reduce the inconvenience caused by the time lag between release .NET and this project. |
|
Fair enough. I'll prepare to release 2.4 as stable. |
AArnott
left a comment
There was a problem hiding this comment.
Ok, I found where this project property actually gets embedded in the tool package (the mpc.runtimeconfig.json file). So I think this will work as advertised.
Currently, there are reports that mpc stops working after each .NET major version upgrade.
How about setting the RollForward in the CLI tool to Major to prevent this?