Skip to content

.NET 6 Update#1355

Merged
AArnott merged 36 commits intoMessagePack-CSharp:developfrom
pCYSl5EDgo:UpdateRoslynv4
Dec 25, 2021
Merged

.NET 6 Update#1355
AArnott merged 36 commits intoMessagePack-CSharp:developfrom
pCYSl5EDgo:UpdateRoslynv4

Conversation

@pCYSl5EDgo
Copy link
Copy Markdown
Contributor

This PR is a solution for #1353.
I do not write test codes for C# 10 because current global.json targets .net 5.0.401.
Another .net 6 update PR is necessary for the tests.

@pCYSl5EDgo pCYSl5EDgo changed the base branch from master to develop December 6, 2021 08:07
@neuecc
Copy link
Copy Markdown
Member

neuecc commented Dec 6, 2021

I think we should add net6.0 to mpc targetframeworks.

@pCYSl5EDgo
Copy link
Copy Markdown
Contributor Author

pCYSl5EDgo commented Dec 6, 2021

Additional work on azure pipeline seems to be needed.

@pCYSl5EDgo
Copy link
Copy Markdown
Contributor Author

Why MessagePackSecurityTests.EqualityComparer_Single fails???

@pCYSl5EDgo
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 1355 in repo neuecc/MessagePack-CSharp

@pCYSl5EDgo pCYSl5EDgo changed the title Update Roslyn V4 .NET 6 Update Dec 9, 2021
@pCYSl5EDgo
Copy link
Copy Markdown
Contributor Author

pCYSl5EDgo commented Dec 9, 2021

@AArnott
Would you review after this CI passes?
I do not know why Unity env test is not conducted.

Changes

Azure Pipelines update

  • windows 2022 & VS2022

.NET 6 Support added

  • global.json change
  • MessagePack.csproj
  • MessagePack.Generator.csproj

MPC C# 10 Test added

  • global using
  • file scoped namespace

Bug fix

  • MessagePackSecurityTest.cs

Dependency update

  • Directory.Build.props

@AArnott
Copy link
Copy Markdown
Collaborator

AArnott commented Dec 25, 2021

@pCYSl5EDgo I have a few minutes now if you need help getting this passing again.

@pCYSl5EDgo
Copy link
Copy Markdown
Contributor Author

pCYSl5EDgo commented Dec 25, 2021

@AArnott
Thanks.
I will need your help when adding .net 5.

@AArnott
Copy link
Copy Markdown
Collaborator

AArnott commented Dec 25, 2021

Thanks!

@AArnott AArnott merged commit fed033d into MessagePack-CSharp:develop Dec 25, 2021
@pCYSl5EDgo pCYSl5EDgo deleted the UpdateRoslynv4 branch December 25, 2021 04:59
@pCYSl5EDgo
Copy link
Copy Markdown
Contributor Author

Thank you @AArnott !
I didn't know how to achieve the thing commit b4c8f2a done.
THANKS!

@AArnott
Copy link
Copy Markdown
Collaborator

AArnott commented Dec 25, 2021

That script update was nearly a direct copy from https://github.com/AArnott/Library.Template/blob/main/tools/Install-DotNetSdk.ps1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants