Skip setting fields when the ctor already took the value#1314
Merged
AArnott merged 3 commits intoMessagePack-CSharp:masterfrom Sep 2, 2021
Merged
Skip setting fields when the ctor already took the value#1314AArnott merged 3 commits intoMessagePack-CSharp:masterfrom
AArnott merged 3 commits intoMessagePack-CSharp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This re-enables setting
readonlyfields (which used to work till #1218) was fixed.To avoid regressing the test that the fix for #1218 added, I also suppress setting fields with values that have already been passed to constructors.
This is a behaviorally observable change.
Fixes #1308
MPC comparison
The new behavior is consistent with mpc-generated code. For this type:
https://github.com/neuecc/MessagePack-CSharp/blob/14556ae3bb41a8807b5a93c9d6a7793bd5d9ab3e/src/MessagePack.UnityClient/Assets/Scripts/Tests/Class1.cs#L679-L693
mpc generates code that only invokes the constructor and returns the result:
https://github.com/neuecc/MessagePack-CSharp/blob/14556ae3bb41a8807b5a93c9d6a7793bd5d9ab3e/sandbox/Sandbox/Generated.cs#L3455-L3457