Target .NET Core 3.1 and 5.0 SDKs in mpc tool#1124
Merged
AArnott merged 3 commits intoMessagePack-CSharp:developfrom Nov 19, 2020
Merged
Target .NET Core 3.1 and 5.0 SDKs in mpc tool#1124AArnott merged 3 commits intoMessagePack-CSharp:developfrom
AArnott merged 3 commits intoMessagePack-CSharp:developfrom
Conversation
AArnott
requested changes
Nov 19, 2020
Collaborator
AArnott
left a comment
There was a problem hiding this comment.
I just tested packing the mpc tool and installing into a project that uses the .NET Core 3.1 SDK, and it failed in a similar way to how mpc fails on the .NET 5 SDK today without changes. We need it to work in both worlds or we alienate a bunch of users.
Repro project:
mpc.zip
AArnott
approved these changes
Nov 19, 2020
Collaborator
AArnott
left a comment
There was a problem hiding this comment.
Oh, never mind. I failed to run dotnet restore after changing the target framework in the repro. It appears to work great
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for the issue #1102 .