Offer API to adjust the ArrayPool#1122
Merged
AArnott merged 4 commits intoMessagePack-CSharp:developfrom Nov 19, 2020
Nirklav:develop
Merged
Offer API to adjust the ArrayPool#1122AArnott merged 4 commits intoMessagePack-CSharp:developfrom Nirklav:develop
AArnott merged 4 commits intoMessagePack-CSharp:developfrom
Nirklav:develop
Conversation
AArnott
requested changes
Nov 18, 2020
Collaborator
AArnott
left a comment
There was a problem hiding this comment.
This looks very good. Thanks for contributing. Just a couple of hopefully small comments.
src/MessagePack.UnityClient/Assets/Scripts/MessagePack/MessagePackSerializerOptions.cs
Show resolved
Hide resolved
src/MessagePack.UnityClient/Assets/Scripts/MessagePack/Utilities.cs
Outdated
Show resolved
Hide resolved
Issue with metgod WithPool was fixed;
AArnott
approved these changes
Nov 19, 2020
src/MessagePack.UnityClient/Assets/Scripts/MessagePack/MessagePackSerializerOptions.cs
Outdated
Show resolved
Hide resolved
src/MessagePack.UnityClient/Assets/Scripts/MessagePack/MessagePackStreamReader.cs
Outdated
Show resolved
Hide resolved
src/MessagePack.UnityClient/Assets/Scripts/MessagePack/MessagePackStreamReader.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Looks fine. I don't have anything to add. |
Member
|
I think it's very good (I also wanted the opportunity to expand the size of the Pool, so I'm personally happy too), thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! We have had problems on our production server with ArrayPool from the .net framework in the MP library.
GC couldn't stop some message pack threads that were in spin lock in the critical section, so the server had random long Stop The World sometimes (some of them reached up to 10 seconds).
So we want to use TlsOverPerCoreLockedStacksArrayPool from .net core. We can take it from core repo to our code, but we can't change DefaultArrayPool to that pool in MP. That’s why I decided to add the possibility to change ArrayPool implementation.
P.S. We are using .net 4.7.2.