♻️ Rename plugins to avoid clashing with SwiftLintPlugins #1862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👻
What does this implement/fix? Explain your changes.
SwiftLint separated their plugins into a separate repository and recommends that people use that version to integrate SwiftLint with their projects. Unfortunately the names they chose clash with the names of the Plugins in this repository. This means that one cannot use MessageKit and the SwiftLint Build Tool Plugin in the same project.
I've removed the Swift part from the names of the plugins in this repository. This fixes the issue but obviously is a pretty primitive fix. Other options I've considered:
Works fine, but there is no option of configuring the command plugin to only run on a single target/module. This means that
make lintleads to linting being run twice on the same files. There is also a difference in the number of files that are linted, probably because of slight configuration differences.Since there is no precedence for such a prefix, I hesitate to introduce one, especially because prefixes have fallen out of favor in general.
Does this close any currently open issues?
As far as I'm aware there is no open issue regarding this issue.
Any relevant logs, error output, etc?
Any other comments?
Where has this been tested?
Xcode 15.4