Added listener for keyboard input mode changes (e.g. emoji keyboard) #1842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👻
What does this implement/fix? Explain your changes.
This fixes an issue in which a change in the keyboard type (e.g. opening the emoji keyboard) does not trigger an update in the keyboard inset.
I've just added a listener for the
currentInputModeDidChangeNotificationpublisher which updates the bottom inset and scrolls to the latest message when received.Does this close any currently open issues?
Nope
Any relevant logs, error output, etc?
Nope
Any other comments?
Here's a screen recording of the current buggy state and the fixed version:
Broken.mp4
Fixed.mp4
Where has this been tested?
Devices/Simulators: iPhone 15 (Simulator)
iOS Version: 17.5
Swift Version: 5.10
MessageKit Version: 4.2.0