duration NaN issue fix #1812
Merged
duration NaN issue fix #1812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If audio url has authentication, sometimes duration came as Nan. Integer(NaN) causes crash.
Kaspik
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
If audio url has authentication, sometimes duration came as Nan. Integer(NaN) causes crash.
Does this close any currently open issues?
No
Any relevant logs, error output, etc?
Thread 1: Fatal error: Float value cannot be converted to Int because it is either infinite or NaN
Any other comments?
Nope
Where has this been tested?
Devices/Simulators: …
Device: iPhone 14 Pro
Simulator: iPhone 14
iOS Version: iOS 16.3 / 16.6
Swift Version: swift 5
MessageKit Version: 3.7.0