Skip to content

Fix typing indicator in advanced example controller #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kaspik merged 3 commits into from
Apr 30, 2023
Merged

Fix typing indicator in advanced example controller #1792

Kaspik merged 3 commits into from
Apr 30, 2023

Conversation

@Kaspik
Copy link
Member

@Kaspik Kaspik commented Apr 30, 2023

  • Don't animate hiding typing indicator if also inserting a message

Seems like there is a race condition where hideIndicator calls performBatchUpdates and the update inside calls insertMessage which does another performBatchUpdates and that crashes.

Fixes #1787

martinpucik
martinpucik approved these changes Apr 30, 2023
View reviewed changes
Copy link
Contributor

@martinpucik martinpucik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@Kaspik Kaspik merged commit 1b7b63c into main Apr 30, 2023
@Kaspik Kaspik deleted the fixAdvancedController branch April 30, 2023 17:37
@Kaspik Kaspik mentioned this pull request Apr 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinpucik martinpucik martinpucik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Advanced Example crashes when typing indicator is hidden

3 participants

@Kaspik @martinpucik