Move messageInputBar from inputAccessoryView to a subview in MessagesViewController
#1704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic keyboard observing from accessory view's observing view
Using KeyboardManager to handle input container view position on keyboard change
Simplify example launch VC
Cleanup of commented and not used code Moved some internal properties to state object Removed iOS 13 available checks
Fix tests build
Move typing indicator methods to extension
Update Changelog
Kaspik
reviewed
May 4, 2022
# Conflicts: # Example/Sources/View Controllers/LaunchViewController.swift
Updated InputBarAccessoryView version to 6.0.0
…it into input-bar-as-subview
Kaspik
approved these changes
May 5, 2022
This was referenced May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Does this close any currently open issues?
Any relevant logs, error output, etc?
Any other comments?
…
Where has this been tested?
Devices/Simulators: …
iOS Version: …
Swift Version: …
MessageKit Version: …