Robustness/speed fixes to work packages#62
Merged
Merged
Conversation
PeterPetrik
approved these changes
Feb 3, 2024
Contributor
|
Would it be possible to add some auto test to catch the error you fixed? |
Contributor
Author
On a second thought, there should not be a particular bug that would make data merging incorrect, it was just that it was very slow even for reasonably sized data, so no change in behavior |
6da7067 to
df563a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60 - works around geodiff bug by only doing rebase when both diffs are not empty (good practice anyway)
Fixes #61 - we were doing diff [wp_base -> master_output] instead of [master_base -> master_output] ... this was creating exceedingly large diffs for larger files,
and may have cause incorrect merges of data as wellFixes #46 - adds DEBUG_DIFFS to wp.py
cc @erpas