proj: fix test suite#4
Merged
Gabriella439 merged 1 commit intoghc944-on-incremental-stdenv-fixfrom Feb 28, 2023
Merged
Conversation
When testing NixOS#213831 internally we ran into a build failure caused by that change for the `proj` package (on `x86_64-linux`). We're not sure how that's possible, but the nature of the build failure was that the network tests for the `proj` package were failing due to missing certificates, so I fixed the build failure by adding `cacert` as a test dependency. It's still not clear (A) why the cert suddenly became necessary after the change in NixOS#213831 or (B) why the build worked at all before, but this is probably the right thing to do regardless because the test suite does have a network component.
9999years
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding upstream PR: NixOS#218719
When testing NixOS#213831 internally we ran into a build failure caused by that change for the
projpackage (onx86_64-linux). We're not sure how that's possible, but the nature of the build failure was that the network tests for theprojpackage were failing due to missing certificates, so I fixed the build failure by addingcacertas a test dependency.It's still not clear (A) why the cert suddenly became necessary after the change in NixOS#213831 or (B) why the build worked at all before, but this is probably the right thing to do regardless because the test suite does have a network component.