Skip to content

TOS#173

Merged
megascatterbomb merged 8 commits intomainfrom
megascatterbomb/tos
Jul 30, 2024
Merged

TOS#173
megascatterbomb merged 8 commits intomainfrom
megascatterbomb/tos

Conversation

@Bash-09
Copy link
Copy Markdown
Contributor

@Bash-09 Bash-09 commented Jul 27, 2024

  • Add tos_agreement_date to preferences for web API
    • Set to empty string to reject
    • Set to valid ISO 8601 date time to say you agreed at that time
    • If not agreed or the agreement happened before the last TOS update, demo uploads are disabled

@Bash-09
Copy link
Copy Markdown
Contributor Author

Bash-09 commented Jul 27, 2024

@megascatterbomb This will need to be tested, as I have not been able to test it.

@Seercat3160
Copy link
Copy Markdown
Contributor

I'd think the TOS text (and checking accepted date vs most current) should be retrieved from the masterbase instance by the client-backend, and sent to the webui. That way, custom UIs can have proper support for TOS, and the TOS is properly based on the masterbase instance in use. How does that compare to the current ideas?

@Bash-09
Copy link
Copy Markdown
Contributor Author

Bash-09 commented Jul 27, 2024

I'd think the TOS text (and checking accepted date vs most current) should be retrieved from the masterbase instance by the client-backend, and sent to the webui. That way, custom UIs can have proper support for TOS, and the TOS is properly based on the masterbase instance in use. How does that compare to the current ideas?

To quote a message from Mega:

tos changes would only happen when the user updates the client (as that's the only time our data collection practices would change)

So combined with the fact that plans are only to support a central Masterbase, I don't think it matters too much at the moment. In an ideal implementation I would agree with you but there's probably no need.

@Bash-09 Bash-09 requested a review from megascatterbomb July 27, 2024 03:41
@megascatterbomb
Copy link
Copy Markdown
Contributor

LGTM. Will hold approval until the matching functionality of the UI is complete and has been tested.

Copy link
Copy Markdown
Contributor

@megascatterbomb megascatterbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved; new functionality utilized by MegaAntiCheat/MegaAntiCheat-UI#111 (review)

@megascatterbomb megascatterbomb merged commit c35ec6c into main Jul 30, 2024
@megascatterbomb megascatterbomb deleted the megascatterbomb/tos branch July 30, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants