Merged
Conversation
Contributor
|
this looks good to me. It can become a part of the monthly (or 'every few months when you remember') workflow to potentially update the pinned the toolchain versions and deal with issues that arrise because of it. |
Bash-09
approved these changes
May 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust-toolchain.tomlto set a fixed version of Rust, so builds don't just start failing when new Clippy lints are addedThank you to Lilith for
complaining on Discordreminding me of the necessity of this.I chose to set the version at
1.78.0because they have already fixed the Clippy lints for it on their branch, so it wouldn't make sense to downgrade.