Conversation
Merged
Contributor
|
Appears to work correctly during a normal ctrl-c
I tested a ctrl-c during startup and it doesn't appear to be handled. As long as the playerlist isn't being accessed at this time it should be okay?
|
Contributor
Author
|
Hm yeah I did only setup the handler right before it enters the main loop, which I guessed would be fine, but it would probably wouldn't hurt to set it up earlier anyways. I've pushed a commit that just moves it earlier before anything that could touch the settings and records, but it is after the masterbase check so that can still be cancelled early. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously I just let Ctrl+C kill the program, but there is a possibility that poor timing could lead to data loss if settings or records have not been written back to disk yet. This branch installs a handler for Ctrl+C which gives the program a chance to save any persistent data before exiting.
It works on Linux but I have not tested it on Windows, although the
tokio::signalmodule claims to be cross-platform so I imagine it will probably work as expected there too.