Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the codebase to MEDS v0.4 by replacing legacy schema field references with the new schema constants and updating version strings.
- Updated import and usage of schema attributes (DataSchema, SubjectSplitSchema, CodeMetadataSchema) throughout the code
- Adjusted dataset metadata to reflect the new MEDS version and updated dependency version in pyproject.toml
- Switched numeric field types from double to float where applicable
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/meds_testing_helpers/infer_dataset_config.py | Replaced legacy field names with DataSchema and SubjectSplitSchema values for improved consistency |
| src/meds_testing_helpers/dataset_generator.py | Updated dataset creation to use new schema properties and updated meds_version from 0.3.3 to 0.4.0 |
| src/meds_testing_helpers/dataset.py | Changed DatasetMetadata to DatasetMetadataSchema, updated numeric types, and modified meds_version values |
| pyproject.toml | Updated the meds dependency to use version "~=0.4.0" |
Comments suppressed due to low confidence (1)
src/meds_testing_helpers/dataset.py:120
- The version string '0.fake.version' appears to be a placeholder. Consider updating it to '0.4.0' to match the upgraded MEDS version for consistency.
meds_version: 0.fake.version
Codecov Report❌ Patch coverage is
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33